4 Commits

Author SHA1 Message Date
joshua 91b352de18 Add closed/past/inactive status badges to user dashboard event titles
Adds an EventStatusBadge component shown next to every event title on
the dashboard (registrations list, upcoming events, tickets, and the
registration modal), with precedence Closed > Past > Inactive when
more than one applies — reusing the badge styling already established
in the supervisor events list.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-23 16:56:32 +02:00
joshua 349686e182 Block self-service payment and cancellation on closed/past registrations
Extends the earlier user-dashboard fix: canEditActive is renamed
canModifyActive and now also gates the "Make payment" and "Cancel
registration" actions, not just editing. Backend enforcement added to
cancelRegistration and createYocoCheckout to block past-event
self-service payment/cancellation server-side (cashup-closed events
were already blocked via assertEventOpen; admins/supervisors are
exempt from the past-date check, consistent with existing overrides).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-23 16:51:10 +02:00
joshua eb46ed8264 Fix user dashboard: buried edit errors, closed events not hidden, closed/past registrations editable
Registration-edit errors were set into a page-level error state rendered
behind the edit modal overlay; they now render inside the modal. The
"Show past events" toggle only hid date-based past events, letting
cashup-closed events leak through by default; a shared isEventOver()
check now covers both, applied to registrations, tickets, and the
Edit button visibility (mirroring the backend's own edit block).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-23 16:43:33 +02:00
joshua 890970fffe Add CHANGELOG.md 2026-07-23 15:38:39 +02:00
4 changed files with 95 additions and 28 deletions
+26
View File
@@ -0,0 +1,26 @@
# Changelog
All notable changes to this project are documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project follows [Semantic Versioning](https://semver.org/).
## [Unreleased]
### Fixed
- User dashboard: registration-edit errors now show inside the edit popup instead of being hidden behind it.
- User dashboard: closed events are now hidden by default alongside past events (revealed via "Show past events"), and the Edit, Make payment, and Cancel registration actions no longer appear for closed or past registrations (also enforced server-side).
### Added
- User dashboard: event titles now show a status badge (Closed / Past / Inactive, in that precedence) wherever they're listed.
## [1.0.0] - 2026-07-23
### Added
- Initial release of the Hope Family Church event management app (Next.js frontend + Express/Prisma backend).
[Unreleased]: https://git.crosscode.co.za/joshua/hope-events/compare/v1.0.0...main
[1.0.0]: https://git.crosscode.co.za/joshua/hope-events/releases/tag/v1.0.0
+5 -1
View File
@@ -788,11 +788,15 @@ const createYocoCheckout = async (req, res) => {
// Branch 1: Registration payment — delegate to internal helper // Branch 1: Registration payment — delegate to internal helper
if (registrationId) { if (registrationId) {
// Authorisation check (the internal helper skips this) // Authorisation check (the internal helper skips this)
const reg = await prisma.registration.findUnique({ where: { id: registrationId }, select: { userId: true, eventId: true } }); const reg = await prisma.registration.findUnique({ where: { id: registrationId }, select: { userId: true, eventId: true, event: { select: { endDate: true } } } });
if (!reg) { res.status(404); throw new Error('Registration not found'); } if (!reg) { res.status(404); throw new Error('Registration not found'); }
if (reg.userId !== userId && req.user.role !== 'admin' && req.user.role !== 'supervisor') { if (reg.userId !== userId && req.user.role !== 'admin' && req.user.role !== 'supervisor') {
res.status(403); throw new Error('Not authorized to create checkout for this registration'); res.status(403); throw new Error('Not authorized to create checkout for this registration');
} }
// If event is in the past, block self-service payment (mirrors the registration-edit block)
if (req.user.role !== 'admin' && req.user.role !== 'supervisor' && reg.event?.endDate && new Date(reg.event.endDate).getTime() < Date.now()) {
res.status(400); throw new Error('This event has already ended; payment can no longer be made for this registration');
}
await assertEventOpen(reg.eventId, res); await assertEventOpen(reg.eventId, res);
// Refresh early-bird pricing — updates priceSnapshot if any tier has expired or sold out. // Refresh early-bird pricing — updates priceSnapshot if any tier has expired or sold out.
@@ -415,7 +415,7 @@ const getUserRegistrations = async (req, res) => {
const whereClause = showPast ? { userId: req.user.id } : { const whereClause = showPast ? { userId: req.user.id } : {
userId: req.user.id, userId: req.user.id,
status: { not: 'cancelled' }, status: { not: 'cancelled' },
event: { endDate: { gte: now } } event: { endDate: { gte: now }, cashupStatus: { not: 'closed' } }
}; };
const registrations = await prisma.registration.findMany({ const registrations = await prisma.registration.findMany({
@@ -583,7 +583,8 @@ const updateRegistrationStatus = async (req, res) => {
const cancelRegistration = async (req, res) => { const cancelRegistration = async (req, res) => {
try { try {
const registration = await prisma.registration.findUnique({ const registration = await prisma.registration.findUnique({
where: { id: req.params.id } where: { id: req.params.id },
include: { event: { select: { endDate: true } } }
}); });
if (!registration) { if (!registration) {
@@ -597,6 +598,12 @@ const cancelRegistration = async (req, res) => {
throw new Error('Not authorized to cancel this registration'); throw new Error('Not authorized to cancel this registration');
} }
// If event is in the past, block self-cancellation (mirrors the edit-block above)
if (req.user.role !== 'admin' && registration.event?.endDate && new Date(registration.event.endDate).getTime() < Date.now()) {
res.status(400);
throw new Error('This event has already ended; registration can no longer be cancelled');
}
await assertEventOpen(registration.eventId, res); await assertEventOpen(registration.eventId, res);
// Check if registration can be cancelled // Check if registration can be cancelled
+55 -25
View File
@@ -9,6 +9,25 @@ import { QrImage } from "@/components/shared/QrImage";
// Helper formatters // Helper formatters
const formatRand = (n: number) => `R ${n.toFixed(2)}`; const formatRand = (n: number) => `R ${n.toFixed(2)}`;
const isFuture = (d: string | Date) => new Date(d).getTime() > Date.now(); const isFuture = (d: string | Date) => new Date(d).getTime() > Date.now();
const isEventOver = (ev: any) =>
!!ev && ((ev.endDate && new Date(ev.endDate).getTime() < Date.now()) || ev.cashupStatus === 'closed');
// Status badge for an event, shown wherever an event title is displayed on this page.
// Precedence when more than one applies: Closed > Past > Inactive.
function EventStatusBadge({ event }: { event: any }) {
if (!event) return null;
let label: string | null = null;
let className = '';
if (event.cashupStatus === 'closed') {
label = 'Closed'; className = 'bg-rose-50 text-rose-700';
} else if (event.endDate && new Date(event.endDate).getTime() < Date.now()) {
label = 'Past'; className = 'bg-amber-50 text-amber-700';
} else if (event.isActive === false) {
label = 'Inactive'; className = 'bg-gray-100 text-gray-500';
}
if (!label) return null;
return <span className={`text-[10px] px-1.5 py-0.5 rounded ${className}`}>{label}</span>;
}
// Effective unit price for an event option (or one of its variants), early-bird aware. // Effective unit price for an event option (or one of its variants), early-bird aware.
// Used by the registration editor, which works off raw /api/events/:id data rather than // Used by the registration editor, which works off raw /api/events/:id data rather than
@@ -443,11 +462,13 @@ export default function UserDashboardPage() {
const [editQuantities, setEditQuantities] = useState<Record<string, number>>({}); const [editQuantities, setEditQuantities] = useState<Record<string, number>>({});
const [editBaseQty, setEditBaseQty] = useState<Record<string, number>>({}); const [editBaseQty, setEditBaseQty] = useState<Record<string, number>>({});
const [editMinQty, setEditMinQty] = useState<Record<string, number>>({}); const [editMinQty, setEditMinQty] = useState<Record<string, number>>({});
const [editError, setEditError] = useState<string | null>(null);
const canEditActive = useMemo(() => { // Whether the active registration's event still permits self-service changes
// (edit items, pay, cancel) — false once the event is past or its cashup is closed.
const canModifyActive = useMemo(() => {
if (!activeReg) return false; if (!activeReg) return false;
const end = activeReg.event?.endDate ? new Date(activeReg.event.endDate).getTime() : Infinity; return !isEventOver(activeReg.event);
return end >= Date.now();
}, [activeReg]); }, [activeReg]);
const editTotal = useMemo(() => { const editTotal = useMemo(() => {
@@ -464,6 +485,7 @@ export default function UserDashboardPage() {
const beginEdit = async () => { const beginEdit = async () => {
if (!activeReg || !token) return; if (!activeReg || !token) return;
setEditError(null);
setEditLoading(true); setEditLoading(true);
try { try {
// Load event options (with variants) for this event // Load event options (with variants) for this event
@@ -507,7 +529,7 @@ export default function UserDashboardPage() {
setEditMinQty(minQtyMap); setEditMinQty(minQtyMap);
setEditMode(true); setEditMode(true);
} catch (e) { } catch (e) {
setError((e as any)?.message || 'Failed to load event options'); setEditError((e as any)?.message || 'Failed to load event options');
} finally { } finally {
setEditLoading(false); setEditLoading(false);
} }
@@ -515,6 +537,7 @@ export default function UserDashboardPage() {
const saveEdit = async () => { const saveEdit = async () => {
if (!activeReg || !token) return; if (!activeReg || !token) return;
setEditError(null);
for (const [key, minQty] of Object.entries(editMinQty)) { for (const [key, minQty] of Object.entries(editMinQty)) {
if (minQty <= 0) continue; if (minQty <= 0) continue;
@@ -523,7 +546,7 @@ export default function UserDashboardPage() {
const eo = editEventOptions.find((o: any) => o.id === eventOptionId); const eo = editEventOptions.find((o: any) => o.id === eventOptionId);
const variant = variantId ? (eo?.variants || []).find((v: any) => v.id === variantId) : null; const variant = variantId ? (eo?.variants || []).find((v: any) => v.id === variantId) : null;
const label = variant ? `${eo?.name || 'item'} (${variant.name})` : (eo?.name || 'item'); const label = variant ? `${eo?.name || 'item'} (${variant.name})` : (eo?.name || 'item');
setError(`Cannot reduce "${label}" below the ${minQty} already issued`); setEditError(`Cannot reduce "${label}" below the ${minQty} already issued`);
return; return;
} }
} }
@@ -539,13 +562,13 @@ export default function UserDashboardPage() {
} }
} }
if (payloadOptions.length === 0) { if (payloadOptions.length === 0) {
setError('Please select at least one item'); setEditError('Please select at least one item');
return; return;
} }
// Enforce client-side: do not reduce below paid // Enforce client-side: do not reduce below paid
const paid = activeBill?.totalPaid || 0; const paid = activeBill?.totalPaid || 0;
if (editTotal < paid) { if (editTotal < paid) {
setError('Cannot reduce items below the amount already paid'); setEditError('Cannot reduce items below the amount already paid');
return; return;
} }
setLoading(true); setLoading(true);
@@ -588,7 +611,7 @@ export default function UserDashboardPage() {
setInfo('Registration updated successfully'); setInfo('Registration updated successfully');
setEditMode(false); setEditMode(false);
} catch (e: any) { } catch (e: any) {
setError(e?.message || 'Failed to update registration'); setEditError(e?.message || 'Failed to update registration');
} finally { } finally {
setLoading(false); setLoading(false);
} }
@@ -635,11 +658,7 @@ export default function UserDashboardPage() {
{registrations {registrations
// Hide cancelled always; hide past unless showPast // Hide cancelled always; hide past unless showPast
.filter((r: any) => r.status !== 'cancelled') .filter((r: any) => r.status !== 'cancelled')
.filter((r: any) => { .filter((r: any) => showPast || !isEventOver(r.event))
if (showPast) return true;
const end = r.event?.endDate ? new Date(r.event.endDate).getTime() : Infinity;
return end >= Date.now();
})
.map((r: any) => { .map((r: any) => {
const bill = billing[r.id]; const bill = billing[r.id];
const isCancelled = r.status === 'cancelled'; const isCancelled = r.status === 'cancelled';
@@ -653,7 +672,10 @@ export default function UserDashboardPage() {
> >
<div className="flex items-start justify-between gap-3"> <div className="flex items-start justify-between gap-3">
<div> <div>
<div className="font-medium">{r.event?.title || r.eventId}</div> <div className="font-medium flex items-center gap-2">
<span>{r.event?.title || r.eventId}</span>
<EventStatusBadge event={r.event} />
</div>
<div className="text-xs text-gray-600"> <div className="text-xs text-gray-600">
Status: {r.status}{isCancelled && <span className="ml-2 inline-block text-[10px] px-1.5 py-0.5 rounded bg-gray-200 text-gray-700">cancelled</span>} Status: {r.status}{isCancelled && <span className="ml-2 inline-block text-[10px] px-1.5 py-0.5 rounded bg-gray-200 text-gray-700">cancelled</span>}
</div> </div>
@@ -726,7 +748,10 @@ export default function UserDashboardPage() {
<ul className="grid md:grid-cols-2 gap-3"> <ul className="grid md:grid-cols-2 gap-3">
{upcomingEvents.map(ev => ( {upcomingEvents.map(ev => (
<li key={ev.id} className="border rounded p-4"> <li key={ev.id} className="border rounded p-4">
<div className="font-medium">{ev.title}</div> <div className="font-medium flex items-center gap-2">
<span>{ev.title}</span>
<EventStatusBadge event={ev} />
</div>
<div className="text-sm text-gray-600">{new Date(ev.startDate).toLocaleString()} - {new Date(ev.endDate).toLocaleString()}</div> <div className="text-sm text-gray-600">{new Date(ev.startDate).toLocaleString()} - {new Date(ev.endDate).toLocaleString()}</div>
<div className="flex flex-wrap gap-2 mt-2"> <div className="flex flex-wrap gap-2 mt-2">
<button <button
@@ -786,12 +811,12 @@ export default function UserDashboardPage() {
</div> </div>
)} )}
</div> </div>
{tickets.filter(t => showPast || (t.event?.endDate ? new Date(t.event.endDate).getTime() >= Date.now() : true)).length === 0 ? ( {tickets.filter(t => showPast || !isEventOver(t.event)).length === 0 ? (
<p className="text-gray-600 text-sm">No tickets yet.</p> <p className="text-gray-600 text-sm">No tickets yet.</p>
) : ( ) : (
<ul className="grid sm:grid-cols-2 lg:grid-cols-3 gap-3"> <ul className="grid sm:grid-cols-2 lg:grid-cols-3 gap-3">
{tickets {tickets
.filter((t: any) => showPast || (t.event?.endDate ? new Date(t.event.endDate).getTime() >= Date.now() : true)) .filter((t: any) => showPast || !isEventOver(t.event))
.map((t: any) => { .map((t: any) => {
const eventDate = t.event?.startDate ? new Date(t.event.startDate) : null; const eventDate = t.event?.startDate ? new Date(t.event.startDate) : null;
const optionName = t.registrationOption?.eventOption?.name || "Ticket"; const optionName = t.registrationOption?.eventOption?.name || "Ticket";
@@ -804,6 +829,7 @@ export default function UserDashboardPage() {
<input type="checkbox" checked={selected[t.id]} onChange={e => toggleSelect(t.id, e.target.checked)} /> <input type="checkbox" checked={selected[t.id]} onChange={e => toggleSelect(t.id, e.target.checked)} />
<span className="font-medium">{t.event?.title || t.eventId}</span> <span className="font-medium">{t.event?.title || t.eventId}</span>
</label> </label>
<EventStatusBadge event={t.event} />
{eventDate && <span className="text-xs text-gray-500">{formatDate(eventDate)}</span>} {eventDate && <span className="text-xs text-gray-500">{formatDate(eventDate)}</span>}
</div> </div>
<div className="text-sm text-gray-700">{type}</div> <div className="text-sm text-gray-700">{type}</div>
@@ -827,11 +853,14 @@ export default function UserDashboardPage() {
</section> </section>
{activeReg && ( {activeReg && (
<div className="fixed inset-0 bg-black/40 flex items-center justify-center z-50" onClick={() => setActiveRegId(null)}> <div className="fixed inset-0 bg-black/40 flex items-center justify-center z-50" onClick={() => { setEditMode(false); setEditError(null); setShowCancelConfirm(false); setActiveRegId(null); }}>
<div className="bg-white rounded-lg shadow-lg max-w-xl w-full mx-4 p-5 max-h-[90vh] overflow-y-auto" onClick={e => e.stopPropagation()}> <div className="bg-white rounded-lg shadow-lg max-w-xl w-full mx-4 p-5 max-h-[90vh] overflow-y-auto" onClick={e => e.stopPropagation()}>
<div className="flex items-center justify-between mb-3"> <div className="flex items-center justify-between mb-3">
<h3 className="text-lg font-semibold">{activeReg.event?.title || activeReg.eventId}</h3> <h3 className="text-lg font-semibold flex items-center gap-2">
<button className="px-2.5 py-1 text-sm rounded bg-gray-100 hover:bg-gray-200 text-gray-700 shadow-sm focus:outline-none focus:ring-2 focus:ring-blue-500 focus:ring-offset-1" onClick={() => { setEditMode(false); setShowCancelConfirm(false); setActiveRegId(null); }}>Close</button> <span>{activeReg.event?.title || activeReg.eventId}</span>
<EventStatusBadge event={activeReg.event} />
</h3>
<button className="px-2.5 py-1 text-sm rounded bg-gray-100 hover:bg-gray-200 text-gray-700 shadow-sm focus:outline-none focus:ring-2 focus:ring-blue-500 focus:ring-offset-1" onClick={() => { setEditMode(false); setEditError(null); setShowCancelConfirm(false); setActiveRegId(null); }}>Close</button>
</div> </div>
<div className="space-y-3"> <div className="space-y-3">
<div> <div>
@@ -847,7 +876,7 @@ export default function UserDashboardPage() {
<div> <div>
<div className="font-medium mb-1 flex items-center justify-between"> <div className="font-medium mb-1 flex items-center justify-between">
<span>Registration items</span> <span>Registration items</span>
{!editMode && canEditActive && ( {!editMode && canModifyActive && (
<button disabled={editLoading} onClick={beginEdit} className="px-2.5 py-1 text-xs bg-blue-600 text-white rounded hover:bg-blue-700 disabled:opacity-50">Edit</button> <button disabled={editLoading} onClick={beginEdit} className="px-2.5 py-1 text-xs bg-blue-600 text-white rounded hover:bg-blue-700 disabled:opacity-50">Edit</button>
)} )}
</div> </div>
@@ -870,6 +899,7 @@ export default function UserDashboardPage() {
</ul> </ul>
) : ( ) : (
<div className="border rounded p-3 space-y-2 bg-gray-50"> <div className="border rounded p-3 space-y-2 bg-gray-50">
{editError && <p className="text-xs text-red-600">{editError}</p>}
{editLoading ? ( {editLoading ? (
<div className="text-sm text-gray-600">Loading options</div> <div className="text-sm text-gray-600">Loading options</div>
) : ( ) : (
@@ -960,7 +990,7 @@ export default function UserDashboardPage() {
})()} })()}
</div> </div>
<div className="flex gap-2"> <div className="flex gap-2">
<button onClick={() => setEditMode(false)} className="px-2.5 py-1 text-xs rounded bg-gray-100 hover:bg-gray-200">Cancel</button> <button onClick={() => { setEditMode(false); setEditError(null); }} className="px-2.5 py-1 text-xs rounded bg-gray-100 hover:bg-gray-200">Cancel</button>
<button onClick={saveEdit} className="px-2.5 py-1 text-xs bg-green-600 text-white rounded hover:bg-green-700">Save</button> <button onClick={saveEdit} className="px-2.5 py-1 text-xs bg-green-600 text-white rounded hover:bg-green-700">Save</button>
</div> </div>
</div> </div>
@@ -986,7 +1016,7 @@ export default function UserDashboardPage() {
onClick={() => router.push(`/dashboard/user/forms?registrationId=${encodeURIComponent(activeReg.id)}`)} onClick={() => router.push(`/dashboard/user/forms?registrationId=${encodeURIComponent(activeReg.id)}`)}
>Attendee forms</button> >Attendee forms</button>
)} )}
{activeBill && activeBill.outstanding > 0 ? ( {canModifyActive && activeBill && activeBill.outstanding > 0 ? (
<button <button
className="px-3 py-1.5 text-sm bg-green-600 text-white rounded hover:bg-green-700 shadow-sm focus:outline-none focus:ring-2 focus:ring-green-500 focus:ring-offset-1" className="px-3 py-1.5 text-sm bg-green-600 text-white rounded hover:bg-green-700 shadow-sm focus:outline-none focus:ring-2 focus:ring-green-500 focus:ring-offset-1"
onClick={() => router.push(`/dashboard/user/pay?registrationId=${encodeURIComponent(activeReg.id)}`)} onClick={() => router.push(`/dashboard/user/pay?registrationId=${encodeURIComponent(activeReg.id)}`)}
@@ -1006,8 +1036,8 @@ export default function UserDashboardPage() {
)} )}
</div> </div>
{/* Cancel registration — only shown when no payments have been made */} {/* Cancel registration — only shown when no payments have been made and the event still permits changes */}
{activeReg.status !== 'cancelled' && (activeBill?.totalPaid ?? 0) === 0 && ( {canModifyActive && activeReg.status !== 'cancelled' && (activeBill?.totalPaid ?? 0) === 0 && (
<div className="pt-3 border-t mt-1"> <div className="pt-3 border-t mt-1">
{!showCancelConfirm ? ( {!showCancelConfirm ? (
<button <button